fix: 1844 - QML ScaleLayout scale charges dialog to accept floats #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
reviewed
Apr 11, 2024
There was a problem hiding this comment.
@rhinoella I appreciate the effort that you've gone to in this solution, and I completely get the logic behind it. But suuuuurely QML has a double spin box that we can use? Having to engineer this as a component for ourselves is absolutely crazy!
|
@trisyoungs Unfortunately not! This is the accepted solution. 🤷♀️ Qt continues to bring more delights |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1847
Creates a custom QML SpinBox that allows for floating-point values with a precision of
0.01.